Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Migrate terms agreement data from owner to user table #145

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Sep 18, 2023

Purpose/Motivation

What is the feature? Why is this being done?

Migrate all the values from OwnerProfile term agreement columns to User term agreement columns
Created a new PR following discussions from here #100

Links to relevant tickets

codecov/engineering-team#390

What does this PR do?

Release 2 of codecov/engineering-team#390 (comment)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Sep 18, 2023

Codecov Report

Patch coverage is 96.55% of modified lines.

Files Changed Coverage
utils/test_utils.py 95.83%
..._auth/migrations/0043_sync_user_terms_agreement.py 100.00%

📢 Thoughts on this report? Let us know!.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Sep 18, 2023

Codecov Report

Merging #145 (0f21937) into main (80ce261) will increase coverage by 0.01%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   95.45%   95.47%   +0.01%     
==========================================
  Files         592      593       +1     
  Lines       14771    14800      +29     
==========================================
+ Hits        14100    14130      +30     
+ Misses        671      670       -1     
Flag Coverage Δ
unit 95.47% <96.55%> (+0.01%) ⬆️
unit-latest-uploader 95.47% <96.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
utils/test_utils.py 97.72% <95.83%> (-2.28%) ⬇️
..._auth/migrations/0043_sync_user_terms_agreement.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #145 (0f21937) into main (80ce261) will increase coverage by 0.02%.
The diff coverage is 96.55%.

@@           Coverage Diff           @@
##            main    #145     +/-   ##
=======================================
+ Coverage   95.37   95.39   +0.02     
=======================================
  Files        707     708      +1     
  Lines      15171   15200     +29     
=======================================
+ Hits       14469   14499     +30     
+ Misses       702     701      -1     
Flag Coverage Δ
unit 95.47% <96.55%> (-0.06%) ⬇️
unit-latest-uploader 95.47% <96.55%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
utils/test_utils.py 97.72% <95.83%> (-2.28%) ⬇️
..._auth/migrations/0043_sync_user_terms_agreement.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@JerrySentry JerrySentry requested a review from a team September 18, 2023 17:54
@JerrySentry JerrySentry merged commit 63c446e into main Sep 20, 2023
22 of 23 checks passed
@JerrySentry JerrySentry deleted the api_390b_new branch September 20, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants