fix: Remove duplicate values in owners.admins and fix adding dupes in… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 95.45% 95.54% +0.09%
==========================================
Files 595 596 +1
Lines 14821 14825 +4
==========================================
+ Hits 14147 14165 +18
+ Misses 674 660 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes |
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=====================================
Coverage 95.45 95.45
=====================================
Files 710 711 +1
Lines 15222 15226 +4
=====================================
+ Hits 14529 14533 +4
Misses 693 693
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
JerrySentry
commented
Sep 22, 2023
adrian-codecov
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
There is a bug when the membership list is loaded in the app by an admin of the org, their ownerid will be added to the admins column regardless if it was already there. On the admin page, it will show hundreds of the same admins for an org.
This fix will remove all duplicate ownerids in owners.admins column for every row. Should lead to improved DB disk usage and API query speed as well.
Note that the migration script runs the "risky" check, which means it doesn't run in CI when building/deploying the app in production. Need to run it manually by dev-ops after the release is deployed.
Links to relevant tickets
codecov/engineering-team#193
What does this PR do?
Fix bug in django
Provide a django migration script to remove existing duplicates
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.