feat: Update comparison result with first pull request type #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=======================================
+ Coverage 95.43 95.44 +0.01
=======================================
Files 709 709
Lines 15193 15203 +10
=======================================
+ Hits 14499 14509 +10
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 95.51% 95.52%
=======================================
Files 594 594
Lines 14793 14803 +10
=======================================
+ Hits 14130 14140 +10
Misses 663 663
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
instead of fetching the missing base commit error and check for first pull, we fetch the new type and handle in gazebo.
Links to relevant tickets
codecov/engineering-team#535
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.