removing and adding fields that we send to tracking tools #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-yaish
force-pushed
the
dana/needed-fields
branch
from
d0529b4
to
01eb68c
Compare
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 95.53% 95.54% +0.01%
==========================================
Files 594 594
Lines 14823 14814 -9
==========================================
- Hits 14161 14154 -7
+ Misses 662 660 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes |
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
=======================================
- Coverage 95.45 95.44 -0.01
=======================================
Files 709 709
Lines 15223 15214 -9
=======================================
- Hits 14530 14521 -9
Misses 693 693
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
joseph-sentry
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditing the sent fields based on the excel sheet we have here https://l.codecov.dev/twR2yU
User signed in and user signed up events were sending extra fields we don't care about. The repo events are sending what we need exactly. Still need to check the
ACCOUNT_UPLOADED_COVERAGE_REPORTfields from PaulLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.