don't save student status to owner if it is false #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=====================================
Coverage 95.51 95.51
=====================================
Files 714 714
Lines 15584 15589 +5
=====================================
+ Hits 14884 14889 +5
Misses 700 700
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 600 600
Lines 15183 15183
=======================================
Hits 14517 14517
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 600 600
Lines 15183 15183
=======================================
Hits 14517 14517
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/student-login
branch
4 times, most recently
from
9ec491e
to
c25b6ae
Compare
scott-codecov
approved these changes
Oct 10, 2023
joseph-sentry
force-pushed
the
joseph/student-login
branch
from
c25b6ae
to
820e2ab
Compare
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/student-login
branch
from
820e2ab
to
b30afc8
Compare
RulaKhaled
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Don't update owner student if student_disabled is True * fix tests for student login Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
We don't want to save the student status of an owner if it's false
Links to relevant tickets
Fixes: codecov/engineering-team#644
What does this PR do?