ref: Add new resolver for ImpactedFiles #183
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 600 600
Lines 15183 15210 +27
=======================================
+ Hits 14517 14544 +27
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 600 600
Lines 15183 15210 +27
=======================================
+ Hits 14517 14544 +27
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=======================================
- Coverage 95.51 95.50 -0.01
=======================================
Files 714 714
Lines 15589 15616 +27
=======================================
+ Hits 14889 14913 +24
- Misses 700 703 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
changed the title
| read_file.return_value = mock_data_from_archive | ||
|
|
||
| query_impacted_files = """ | ||
| query ImpactedFilesNew( |
There was a problem hiding this comment.
Optional: if the query is the same bw this and the other filter file, maybe add it to the setup to avoid DRY
Purpose/Motivation
Make a new resolver for ImpactedFiles with a slight change in logic where if there are no coverage with list of flags provided for filtering it will return an error instead of show all files.
Links to relevant tickets
codecov/engineering-team#641
What does this PR do?
Flags refactoring
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.