Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure Okta iss has proper form #190

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

scott-codecov
Copy link
Contributor

Purpose/Motivation

Validate user input before using it as part of a redirect.

Fixes https://github.com/codecov/codecov-api/security/code-scanning/9

Links to relevant tickets

https://github.com/codecov/internal-issues/issues/67

What does this PR do?

Ensures that the Okta iss is of the form https://<subdomain>.okta.com

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 13, 2023

Codecov Report

Merging #190 (59f00de) into main (576edd4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   95.61%   95.62%           
=======================================
  Files         600      600           
  Lines       15204    15208    +4     
=======================================
+ Hits        14538    14542    +4     
  Misses        666      666           
Flag Coverage Δ
unit 95.62% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/okta.py 100.00% <100.00%> (ø)

Impacted file tree graph

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #190 (0b62de1) into main (576edd4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0b62de1 differs from pull request most recent head 59f00de. Consider uploading reports for the commit 59f00de to get more accurate results

@@          Coverage Diff          @@
##            main    #190   +/-   ##
=====================================
  Coverage   95.52   95.52           
=====================================
  Files        714     714           
  Lines      15610   15612    +2     
=====================================
+ Hits       14910   14912    +2     
  Misses       700     700           
Flag Coverage Δ
unit 95.62% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/okta.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (576edd4) 95.61% compared to head (59f00de) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   95.61%   95.62%           
=======================================
  Files         600      600           
  Lines       15204    15208    +4     
=======================================
+ Hits        14538    14542    +4     
  Misses        666      666           
Flag Coverage Δ
unit 95.62% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-codecov scott-codecov merged commit 4c595ac into main Oct 17, 2023
15 of 16 checks passed
@scott-codecov scott-codecov deleted the scott/fix-okta-redirect branch October 17, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants