Only auto-activate if state has changed, remove update to repo.updatestamp

[scott-codecov]

Purpose/Motivation

This query was quite slow at times. See here for p99 response time > 60s in some cases: https://codecov.sentry.io/performance/summary/spans/db:500d772238719a7c/?environment=production&project=5215654&query=http.method%3APOST&statsPeriod=7d&transaction=%2Fupload%2F%7Bversion%7D%2F

Presumably there's just lots of contention for that repo row and updates are waiting on locks. The actual query itself is conditional on the primary key so it's not like adding an index would speed that up or anything.

Links to relevant tickets

Depends on codecov/worker#150

What does this PR do?

• Removes the update to repos.updatestamp (this will now happen in the worker - see here: Update repo updatestamp in upload task worker#150)
• only update the active/activated/deleted state if it actually changed

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e53c76) 95.61% compared to head (b18f038) 95.61%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         600      600           
  Lines       15222    15223    +1     
=======================================
+ Hits        14555    14556    +1     
  Misses        667      667           

Flag	Coverage Δ
unit	95.61% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	95.61% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-public-qa]

Codecov Report

Merging #200 (b18f038) into main (0e53c76) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         600      600           
  Lines       15222    15223    +1     
=======================================
+ Hits        14555    14556    +1     
  Misses        667      667           

Flag	Coverage Δ
unit	95.61% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	95.61% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
upload/helpers.py	93.42% <100.00%> (+0.02%)	⬆️

[codecov]

Codecov Report

Merging #200 (b18f038) into main (0e53c76) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

@@          Coverage Diff          @@
##            main    #200   +/-   ##
=====================================
  Coverage   95.52   95.52           
=====================================
  Files        714     714           
  Lines      15628   15629    +1     
=====================================
+ Hits       14928   14929    +1     
  Misses       700     700           

Flag	Coverage Δ
unit	95.61% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	95.61% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
upload/helpers.py Critical	93.42% <100.00%> (+0.02%)	⬆️

[codecov-staging]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.