-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a filter for public/private repo filter for viewableRepository #224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 602 602
Lines 15304 15307 +3
=======================================
+ Hits 14632 14635 +3
Misses 672 672
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 602 602
Lines 15304 15307 +3
=======================================
+ Hits 14632 14635 +3
Misses 672 672
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for the quick turn!
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #224 +/- ##
=======================================
+ Coverage 95.25 95.51 +0.26
=======================================
Files 716 716
Lines 15661 15700 +39
=======================================
+ Hits 14917 14995 +78
+ Misses 744 705 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* main: Test ats run (#229) Release 23.11.2 (#228) feat: Add comparison endpoint for impacted files (#212) Update shared version (#226) feat: add a filter for public/private repo filter for viewableRepositories (#224) fix: speedup flag filtering in GraphQL API (#223) fix: Disable early notify comment (#219) Add 'value' key to the plan representation resolver (#216) 713 adjust available plans in plan service (#214) feat: Allow upload requests originating from Shelter to set storage path (#172)
Purpose/Motivation
What is the feature? Why is this being done?
viewableRepository
resolver, add ability to filter repo list by public/private.isPublic
is not provided it will return both public and private reposisPublic=true
it will only return public reposisPublic=false
it will only return private reposLinks to relevant tickets
codecov/engineering-team#724
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.