Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a filter for public/private repo filter for viewableRepository #224

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

  • On GraphQL viewableRepository resolver, add ability to filter repo list by public/private.
  • If isPublic is not provided it will return both public and private repos
  • If isPublic=true it will only return public repos
  • If isPublic=false it will only return private repos

Links to relevant tickets

codecov/engineering-team#724

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@codecov-qa
Copy link

codecov-qa bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c1a3d4) 95.60% compared to head (291c303) 95.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         602      602           
  Lines       15304    15307    +3     
=======================================
+ Hits        14632    14635    +3     
  Misses        672      672           
Flag Coverage Δ
unit 95.60% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Nov 1, 2023

Codecov Report

Merging #224 (291c303) into main (7c1a3d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         602      602           
  Lines       15304    15307    +3     
=======================================
+ Hits        14632    14635    +3     
  Misses        672      672           
Flag Coverage Δ
unit 95.60% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/actions/repository.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for the quick turn!

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #224 (f65ad71) into main (7c1a3d4) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Current head f65ad71 differs from pull request most recent head 291c303. Consider uploading reports for the commit 291c303 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

@@           Coverage Diff           @@
##            main    #224     +/-   ##
=======================================
+ Coverage   95.25   95.51   +0.26     
=======================================
  Files        716     716             
  Lines      15661   15700     +39     
=======================================
+ Hits       14917   14995     +78     
+ Misses       744     705     -39     
Flag Coverage Δ
unit 95.60% <100.00%> (?)
unit-latest-uploader 95.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/actions/repository.py 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

@JerrySentry JerrySentry merged commit 39d2b2c into main Nov 2, 2023
16 checks passed
@JerrySentry JerrySentry deleted the api_724 branch November 2, 2023 00:56
scott-codecov added a commit that referenced this pull request Nov 6, 2023
* main:
  Test ats run (#229)
  Release 23.11.2 (#228)
  feat: Add comparison endpoint for impacted files (#212)
  Update shared version (#226)
  feat: add a filter for public/private repo filter for viewableRepositories (#224)
  fix: speedup flag filtering in GraphQL API (#223)
  fix: Disable early notify comment (#219)
  Add 'value' key to the plan representation resolver  (#216)
  713 adjust available plans in plan service (#214)
  feat: Allow upload requests originating from Shelter to set storage path (#172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants