Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set SameSite=None; Secure for sessionid cookie #24

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

scott-codecov
Copy link
Contributor

Gazebo preview deploys are currently not working since the sessionid cookie is not being sent to the API (due to SameSite=Lax)

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it 🔥

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #24 (58b0fb3) into main (0c219cb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##            main     #24     +/-   ##
=======================================
- Coverage   95.24   95.23   -0.01     
=======================================
  Files        560     560             
  Lines      14055   14057      +2     
=======================================
  Hits       13386   13386             
- Misses       669     671      +2     
Flag Coverage Δ
unit 95.22% <0.00%> (-0.02%) ⬇️
unit-latest-uploader 95.22% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov/settings_staging.py 0.00% <0.00%> (ø)

@scott-codecov scott-codecov merged commit 03c4ce6 into main Jul 21, 2023
6 of 8 checks passed
@scott-codecov scott-codecov deleted the scott/staging-cookie-same-site branch July 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants