fix(logging): referer -> referrer #250
Conversation
historical nuances be damned, it says referrer in the dictionary!
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 610 610
Lines 15714 15714
=======================================
Hits 15030 15030
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=====================================
Coverage 95.55 95.55
=====================================
Files 724 724
Lines 16121 16121
=====================================
Hits 15404 15404
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -45,7 +45,7 @@ class CustomGunicornLogFormatter(JsonFormatter): | |||
| "levelname": "level", | |||
| "r": "request", | |||
| "a": "useragent", | |||
| "f": "referer", # the biggest concern in my mind: should this be correctly spelled historically (one r) or correctly spelled linguistically (two r) | |||
| "f": "referrer", | |||
There was a problem hiding this comment.
qq: does this break backwards compatibility with anything?
There was a problem hiding this comment.
nope -- this is only for the querying in our logs, which has been flowing for less than a day.
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 610 610
Lines 15714 15714
=======================================
Hits 15030 15030
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
historical nuances be damned, it says referrer in the dictionary!