Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add admin trial start (#846) #288

Merged
merged 6 commits into from
Dec 13, 2023
Merged

feat: Add admin trial start (#846) #288

merged 6 commits into from
Dec 13, 2023

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Dec 4, 2023

Purpose/Motivation

Add an action in the Owners page on the Admin panel to manually start trials for any free tier orgs with the specified end date

Links to relevant tickets

codecov/engineering-team#846

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e1cca5) 95.64% compared to head (7263e28) 95.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         612      612              
  Lines       15770    15820      +50     
==========================================
+ Hits        15084    15134      +50     
  Misses        686      686              
Flag Coverage Δ
unit 95.66% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 95.66% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e1cca5) 95.56% compared to head (7263e28) 95.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #288     +/-   ##
=======================================
+ Coverage   95.56   95.57   +0.01     
=======================================
  Files        726     726             
  Lines      16178   16228     +50     
=======================================
+ Hits       15459   15509     +50     
  Misses       719     719             
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Dec 12, 2023

Codecov Report

Merging #288 (7263e28) into main (9e1cca5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         612      612              
  Lines       15770    15820      +50     
==========================================
+ Hits        15084    15134      +50     
  Misses        686      686              
Flag Coverage Δ
unit 95.66% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 95.66% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/admin.py 100.00% <100.00%> (ø)
plan/service.py 96.85% <100.00%> (+0.21%) ⬆️
plan/test_plan.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Have you tried using this in the admin and saving an unrelated field? I'm wondering if the "required" in line 26 of the admin.py can lead to that

@JerrySentry
Copy link
Contributor Author

Lgtm. Have you tried using this in the admin and saving an unrelated field? I'm wondering if the "required" in line 26 of the admin.py can lead to that

Should be fine as this isn't the normal page where you would edit all the fields, this is a separate page you navigate to on the admin actions drop down.

See codecov/engineering-team#846 (comment)

@JerrySentry JerrySentry merged commit 566c312 into main Dec 13, 2023
20 checks passed
@JerrySentry JerrySentry deleted the api_846 branch December 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants