feat: Start populating report_type column #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.01%
==========================================
Files 612 612
Lines 15734 15743 +9
==========================================
+ Hits 15050 15058 +8
- Misses 684 685 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.01%
==========================================
Files 612 612
Lines 15734 15743 +9
==========================================
+ Hits 15050 15058 +8
- Misses 684 685 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
commented
Dec 6, 2023
| if report_type == CommitReport.ReportType.COVERAGE: | ||
| queryset = queryset.coverage_reports() | ||
| else: | ||
| queryset = queryset.filter(report_type=report_type) |
There was a problem hiding this comment.
This will be tested when I implement the upload endpoint for bundle analysis
joseph-sentry
approved these changes
Dec 6, 2023
JerrySentry
approved these changes
Dec 6, 2023
giovanni-guidini
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Follow up from #287
Links to relevant tickets
N/A
What does this PR do?
Starts populating the
report_typecolumn when we create new commit reports or query for existing commit reports (as part of upload).