Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bundle analysis upload endpoint #299

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Dec 8, 2023

Purpose/Motivation

Ingest data from the bundle analysis plugin.

Links to relevant tickets

N/A

What does this PR do?

Adds a new endpoint POST /upload/bundle_analysis/v1 for ingesting bundle analysis data.

  • requires at least commit and slug arguments in the JSON body
  • returns presigned-PUT storage URL
  • enqueues upload task with report_type="bundle_analysis"

Should not be merged before codecov/worker#190 is deployed otherwise bundle analysis uploads will be processed as coverage uploads and fail.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (67398dc) 95.57% compared to head (cf2217f) 95.59%.
Report is 1 commits behind head on main.

❗ Current head cf2217f differs from pull request most recent head 91adc33. Consider uploading reports for the commit 91adc33 to get more accurate results

Files Patch % Lines
upload/views/bundle_analysis.py 98.18% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #299     +/-   ##
=======================================
+ Coverage   95.57   95.59   +0.02     
=======================================
  Files        726     727      +1     
  Lines      16231   16335    +104     
=======================================
+ Hits       15512   15614    +102     
- Misses       719     721      +2     
Flag Coverage Δ
unit 95.68% <98.55%> (-0.27%) ⬇️
unit-latest-uploader 95.68% <98.55%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to all make sense to me 🚀

@scott-codecov scott-codecov force-pushed the scott/bundle-analyis-upload branch 2 times, most recently from f1d636b to 5902404 Compare December 8, 2023 18:15
@codecov-qa
Copy link

codecov-qa bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (614bc00) 95.95% compared to head (91adc33) 95.96%.

Files Patch % Lines
upload/views/bundle_analysis.py 98.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +0.01%     
==========================================
  Files         611      612       +1     
  Lines       15729    15795      +66     
==========================================
+ Hits        15093    15158      +65     
- Misses        636      637       +1     
Flag Coverage Δ
unit 95.96% <98.57%> (+0.01%) ⬆️
unit-latest-uploader 95.96% <98.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Dec 8, 2023

Codecov Report

Merging #299 (91adc33) into main (614bc00) will increase coverage by 0.01%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +0.01%     
==========================================
  Files         611      612       +1     
  Lines       15729    15795      +66     
==========================================
+ Hits        15093    15158      +65     
- Misses        636      637       +1     
Flag Coverage Δ
unit 95.96% <98.57%> (+0.01%) ⬆️
unit-latest-uploader 95.96% <98.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/task/task.py 80.90% <ø> (ø)
upload/helpers.py 94.00% <100.00%> (+0.22%) ⬆️
upload/urls.py 100.00% <100.00%> (ø)
upload/views/bundle_analysis.py 98.21% <98.21%> (ø)

Impacted file tree graph

@codecov-staging
Copy link

codecov-staging bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Patch % Lines
upload/views/bundle_analysis.py 98.21% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@scott-codecov scott-codecov merged commit c69525c into main Dec 19, 2023
31 of 33 checks passed
@scott-codecov scott-codecov deleted the scott/bundle-analyis-upload branch December 19, 2023 18:11
scott-codecov added a commit that referenced this pull request Dec 21, 2023
* main:
  feat: tokenless auth (part II) (#308)
  feat: tokenless auth (part I) (#304)
  fix: stop returning 400 code when user installs github app (#314)
  Always send to mkto (#313)
  feat: Bundle analysis upload endpoint (#299)
  Reduce db queries coming from health endpoint (#311)
scott-codecov added a commit that referenced this pull request Dec 21, 2023
* main:
  feat: tokenless auth (part II) (#308)
  feat: tokenless auth (part I) (#304)
  fix: stop returning 400 code when user installs github app (#314)
  Always send to mkto (#313)
  feat: Bundle analysis upload endpoint (#299)
  Reduce db queries coming from health endpoint (#311)
scott-codecov added a commit that referenced this pull request Dec 21, 2023
* main:
  feat: tokenless auth (part II) (#308)
  feat: tokenless auth (part I) (#304)
  fix: stop returning 400 code when user installs github app (#314)
  Always send to mkto (#313)
  feat: Bundle analysis upload endpoint (#299)
  Reduce db queries coming from health endpoint (#311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants