Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attempt to fix flags sessions failing #301

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
The error here is failing the flags selector, this is an attempt of resolving the error https://codecov.sentry.io/issues/4522401648/?environment=production&project=5215654&q[…]referrer=issue-stream&statsPeriod=1h&stream_index=1&utc=true

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d91292) 95.56% compared to head (dcf0635) 95.54%.

❗ Current head dcf0635 differs from pull request most recent head dd9bd94. Consider uploading reports for the commit dd9bd94 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #301     +/-   ##
=======================================
- Coverage   95.56   95.54   -0.02     
=======================================
  Files        726     726             
  Lines      16178   16178             
=======================================
- Hits       15459   15456      -3     
- Misses       719     722      +3     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d91292) 95.64% compared to head (dd9bd94) 95.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         612      612           
  Lines       15770    15770           
=======================================
  Hits        15084    15084           
  Misses        686      686           
Flag Coverage Δ
unit 95.64% <ø> (ø)
unit-latest-uploader 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #301 (dd9bd94) into main (2d91292) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         612      612           
  Lines       15770    15770           
=======================================
  Hits        15084    15084           
  Misses        686      686           
Flag Coverage Δ
unit 95.64% <ø> (ø)
unit-latest-uploader 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/report.py 96.63% <ø> (ø)

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants