Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update logout_view to redirect to dashboard_url #309

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

joseph-sentry
Copy link
Contributor

What does this PR do?

  • change logout_view redirect url to hardcoded dashboard url in settings

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd33523) 95.57% compared to head (8adaab8) 95.57%.
Report is 1 commits behind head on main.

❗ Current head 8adaab8 differs from pull request most recent head 634f89a. Consider uploading reports for the commit 634f89a to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #309   +/-   ##
=====================================
  Coverage   95.57   95.57           
=====================================
  Files        726     726           
  Lines      16228   16227    -1     
=====================================
- Hits       15509   15508    -1     
  Misses       719     719           
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@codecov-qa
Copy link

codecov-qa bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e55bcdd) 95.95% compared to head (0a06708) 95.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         611      611           
  Lines       15722    15722           
=======================================
  Hits        15086    15086           
  Misses        636      636           
Flag Coverage Δ
unit 95.95% <100.00%> (ø)
unit-latest-uploader 95.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #309 (0a06708) into main (e55bcdd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         611      611           
  Lines       15722    15722           
=======================================
  Hits        15086    15086           
  Misses        636      636           
Flag Coverage Δ
unit 95.95% <100.00%> (ø)
unit-latest-uploader 95.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/logout.py 100.00% <100.00%> (ø)

Impacted file tree graph

@joseph-sentry joseph-sentry merged commit 67398dc into main Dec 15, 2023
17 checks passed
@joseph-sentry joseph-sentry deleted the joseph/update-redirect-url branch December 15, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants