feat: add resolver to expose private repos #317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 613 613
Lines 15877 15884 +7
=======================================
+ Hits 15242 15249 +7
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 613 613
Lines 15877 15884 +7
=======================================
+ Hits 15242 15249 +7
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=====================================
Coverage 95.62 95.62
=====================================
Files 728 728
Lines 16386 16393 +7
=====================================
+ Hits 15668 15675 +7
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -569,3 +569,21 @@ def test_owner_query_with_no_service(self): | |||
|
|
|||
| assert res["errors"][0]["message"] == MissingService.message | |||
| assert res["data"]["owner"] is None | |||
|
|
|||
| def test_owner_query_with_private_repos(self): | |||
There was a problem hiding this comment.
might be worth it to test if owner doesn't have any private repos
Purpose/Motivation
We're adding a resolver to surface whether a repo has any private repos.
Links to relevant tickets
codecov/engineering-team#939
What does this PR do?
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.