feat: Add sentry spotlight (#297) #322
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15920 15922 +2
=======================================
+ Hits 15285 15288 +3
+ Misses 635 634 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
+ Coverage 95.63 95.64 +0.01
=======================================
Files 730 730
Lines 16431 16433 +2
=======================================
+ Hits 15713 15716 +3
+ Misses 718 717 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15920 15922 +2
=======================================
+ Hits 15285 15288 +3
+ Misses 635 634 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -526,6 +526,10 @@ | |||
| ), | |||
| }, | |||
| ) | |||
| elif IS_DEV: | |||
| sentry_sdk.init( | |||
There was a problem hiding this comment.
Do we also want the dsn param here?
There was a problem hiding this comment.
I don't think so, in the docs it says:
If you want your Sentry SDKs to talk to the Sidecar, enable the spotlight setting. You don’t need a dsn for Spotlight to work.
and we don't actually have aSENTRY_DSNin dev.
Purpose/Motivation
What is the feature? Why is this being done?
Enable Sentry Spotlight when in development environment.
Links to relevant tickets
#297
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.