Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add primary language field to repository GQL #323

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Dec 29, 2023

Purpose/Motivation

What is the feature? Why is this being done?

Following up from #321, adds the language field to the Repository type. This will be consumed in gazebo to conditionally render an ATS tab. This PR closes codecov/engineering-team#930.

Links to relevant tickets

codecov/engineering-team#930

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94bc9b0) 95.64% compared to head (62ec1bb) 95.64%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #323   +/-   ##
=====================================
  Coverage   95.64   95.64           
=====================================
  Files        730     730           
  Lines      16433   16436    +3     
=====================================
+ Hits       15716   15719    +3     
  Misses       717     717           
Flag Coverage Δ
unit 96.01% <100.00%> (?)
unit-latest-uploader 96.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@94bc9b0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage        ?   96.01%           
=======================================
  Files           ?      615           
  Lines           ?    15925           
  Branches        ?        0           
=======================================
  Hits            ?    15291           
  Misses          ?      634           
  Partials        ?        0           
Flag Coverage Δ
unit 96.01% <100.00%> (?)
unit-latest-uploader 96.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Dec 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@94bc9b0). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage        ?   96.01%           
=======================================
  Files           ?      615           
  Lines           ?    15925           
  Branches        ?        0           
=======================================
  Hits            ?    15291           
  Misses          ?      634           
  Partials        ?        0           
Flag Coverage Δ
unit 96.01% <100.00%> (?)
unit-latest-uploader 96.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 2, 2024 15:28
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [Draft] Add language field to repo gql [Draft] Add language field to repository GQL Jan 2, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [Draft] Add language field to repository GQL [feat] Add language field to repository GQL Jan 2, 2024
Copy link
Contributor

@JerrySentry JerrySentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main discussion here: https://sentry.slack.com/archives/C04LW8R1M2N/p1704210521062999

Its fine to add this field to the GQL response, however beware what this language value represents and how it will be consumed. Its an arbitrary value retrieved from git providers' APIs, just because it shows one language doesn't mean that language exists in the repo nor does it mean it does not have any other languages.

@rohitvinnakota-codecov
Copy link
Contributor Author

codecov/engineering-team#811 (comment)

Main discussion here: https://sentry.slack.com/archives/C04LW8R1M2N/p1704210521062999

Its fine to add this field to the GQL response, however beware what this language value represents and how it will be consumed. Its an arbitrary value retrieved from git providers' APIs, just because it shows one language doesn't mean that language exists in the repo nor does it mean it does not have any other languages.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [feat] Add language field to repository GQL [feat] Add primary language field to repository GQL Jan 3, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit bcbcc29 into main Jan 3, 2024
21 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota-add-language-repo-gql branch January 3, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Add an isATSConfigured field to the repository GQL type
2 participants