Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

957 add frp proxy #327

Merged
merged 5 commits into from
Jan 5, 2024
Merged

957 add frp proxy #327

merged 5 commits into from
Jan 5, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

We occasionally test Stripe locally, and to do so we need to expose our local setup to the world. We normally use Ngrok, but we have an inhouse solution, this ticket, instead to save us some money.

What does this PR do?

  • Add frpc proxy setup information + minutiae to ensure the new setup works

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6f2848) 96.01% compared to head (20e6e9e) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         615      615           
  Lines       15944    15944           
=======================================
  Hits        15308    15308           
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <ø> (ø)
unit-latest-uploader 96.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 3, 2024

Codecov Report

Merging #327 (20e6e9e) into main (c6f2848) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         615      615           
  Lines       15944    15944           
=======================================
  Hits        15308    15308           
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <ø> (ø)
unit-latest-uploader 96.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_dev.py 100.00% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6f2848) 95.63% compared to head (20e6e9e) 95.63%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #327   +/-   ##
=====================================
  Coverage   95.63   95.63           
=====================================
  Files        730     730           
  Lines      16455   16455           
=====================================
  Hits       15736   15736           
  Misses       719     719           
Flag Coverage Δ
unit 96.01% <ø> (ø)
unit-latest-uploader 96.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov merged commit 14d51a2 into main Jan 5, 2024
20 checks passed
@adrian-codecov adrian-codecov deleted the 957-add-frp-proxy branch January 5, 2024 22:11
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants