Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove feature flag for tokenless #328

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

giovanni-guidini
Copy link
Contributor

Removes the reollout for tokenless uploads.
Prepping tokenless for GA

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Removes the reollout for tokenless uploads.
Prepping tokenless for GA
@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9a1f25) 96.07% compared to head (76a41e0) 96.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   96.07%   96.05%   -0.02%     
==========================================
  Files         625      625              
  Lines       16199    16195       -4     
==========================================
- Hits        15563    15556       -7     
- Misses        636      639       +3     
Flag Coverage Δ
unit 96.05% <ø> (-0.02%) ⬇️
unit-latest-uploader 96.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 4, 2024

Codecov Report

Merging #328 (76a41e0) into main (a9a1f25) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   96.07%   96.05%   -0.02%     
==========================================
  Files         625      625              
  Lines       16199    16195       -4     
==========================================
- Hits        15563    15556       -7     
- Misses        636      639       +3     
Flag Coverage Δ
unit 96.05% <ø> (-0.02%) ⬇️
unit-latest-uploader 96.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/authentication/repo_auth.py 98.14% <ø> (+0.57%) ⬆️
rollouts/__init__.py 0.00% <ø> (-100.00%) ⬇️

Impacted file tree graph

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9a1f25) 95.70% compared to head (76a41e0) 95.70%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #328   +/-   ##
=====================================
  Coverage   95.70   95.70           
=====================================
  Files        740     740           
  Lines      16715   16711    -4     
=====================================
- Hits       15996   15993    -3     
+ Misses       719     718    -1     
Flag Coverage Δ
unit 96.05% <ø> (-0.02%) ⬇️
unit-latest-uploader 96.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giovanni-guidini giovanni-guidini merged commit eec38e0 into main Jan 22, 2024
18 of 22 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/remove-tokenless-flags branch January 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants