-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update and retrieve bundle_analysis_enabled field #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 619 619
Lines 15969 15978 +9
=======================================
+ Hits 15333 15342 +9
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=====================================
Coverage 95.64 95.64
=====================================
Files 734 734
Lines 16483 16492 +9
=====================================
+ Hits 15764 15773 +9
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 619 619
Lines 15969 15978 +9
=======================================
+ Hits 15333 15342 +9
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -324,10 +324,15 @@ def resolve_repository_config(repository: Repository, info): | |||
|
|||
|
|||
@repository_bindable.field("primaryLanguage") | |||
def resolve_languate(repository: Repository, info): | |||
def resolve_language(repository: Repository, info): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add return types for both functions please?
Purpose/Motivation
What is the feature? Why is this being done?
For client app to know whether use has bundle analysis enabled:
Links to relevant tickets
codecov/engineering-team#1005
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.