Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update and retrieve bundle_analysis_enabled field #336

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

For client app to know whether use has bundle analysis enabled:

  • When a upload endpoint is called for a bundle analysis type, set the flag to true in DB.
  • Allow GQL to query this field

Links to relevant tickets

codecov/engineering-team#1005

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jan 10, 2024

Codecov Report

Merging #336 (41346c2) into main (f6a2227) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         619      619           
  Lines       15969    15978    +9     
=======================================
+ Hits        15333    15342    +9     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)
upload/views/bundle_analysis.py 98.38% <100.00%> (+0.17%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6a2227) 95.64% compared to head (41346c2) 95.64%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #336   +/-   ##
=====================================
  Coverage   95.64   95.64           
=====================================
  Files        734     734           
  Lines      16483   16492    +9     
=====================================
+ Hits       15764   15773    +9     
  Misses       719     719           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6a2227) 96.01% compared to head (41346c2) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         619      619           
  Lines       15969    15978    +9     
=======================================
+ Hits        15333    15342    +9     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -324,10 +324,15 @@ def resolve_repository_config(repository: Repository, info):


@repository_bindable.field("primaryLanguage")
def resolve_languate(repository: Repository, info):
def resolve_language(repository: Repository, info):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add return types for both functions please?

@JerrySentry JerrySentry merged commit e9a33a2 into main Jan 11, 2024
20 of 21 checks passed
@JerrySentry JerrySentry deleted the api_1005b branch January 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants