feat: GithubAppInstallation model #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
added a commit
that referenced
this pull request
Jan 18, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. depends on: #346
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
32cbe7e
to
e0cb312
Compare
giovanni-guidini
added a commit
that referenced
this pull request
Jan 18, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. depends on: #346
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 624 625 +1
Lines 16171 16196 +25
=======================================
+ Hits 15535 15560 +25
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 624 625 +1
Lines 16171 16196 +25
=======================================
+ Hits 15535 15560 +25
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Model definitions for GithubAppInstallation. This will unlock multiple apps for an org. It also will improve how we keep track of what repos an installation can access. context: codecov/engineering-team#969
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
e0cb312
to
a58ea09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
- Coverage 95.69 95.67 -0.02
=======================================
Files 738 740 +2
Lines 16670 16842 +172
=======================================
+ Hits 15951 16112 +161
- Misses 719 730 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giovanni-guidini
added a commit
that referenced
this pull request
Jan 18, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
requested review from
adrian-codecov,
joseph-sentry and
matt-codecov
matt-codecov
approved these changes
Jan 18, 2024
| GITHUB_APP_INSTALLATION_DEFAULT_NAME = "codecov_app_installation" | ||
|
|
||
|
|
||
| class GithubAppInstallation( |
There was a problem hiding this comment.
do we also need an app id column? since we may use sentry's app or support multiple apps
There was a problem hiding this comment.
the "installation_id" is the "app_id"
| # replacement for owner.integration_id | ||
| # installation id GitHub sends us in the installation-related webhook events | ||
| installation_id = models.IntegerField(null=False, blank=False) | ||
| name = models.TextField(default=GITHUB_APP_INSTALLATION_DEFAULT_NAME) |
There was a problem hiding this comment.
I think this is what will differentiate the type of apps. As you mentioned above, we might use sentry's app or support multiple apps. This is how we know which is which.
giovanni-guidini
added a commit
that referenced
this pull request
Jan 18, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
that referenced
this pull request
Jan 19, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
that referenced
this pull request
Jan 19, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
that referenced
this pull request
Jan 19, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
that referenced
this pull request
Jan 19, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
that referenced
this pull request
Jan 19, 2024
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jan 19, 2024
These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jan 24, 2024
These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970
giovanni-guidini
added a commit
that referenced
this pull request
Jan 24, 2024
* feat: use GithubAppInstallation in api Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346 * refactor webhook handling related to gh app installation * use ghapp when getting torngit adapter Considers ghapp installations when deciding if a torngit adapter is for a repo with integration or not. If a ghapp installation exist then repo is considered to be using integration if it's covered by the installation. Otherwise previous behavior is used. The test `test_get_adapter_sets_token_to_bot_when_user_not_authenticated` includes `owner` as `None` when calling `RepoProviderService.get_adapter` so I'm assuming that can happen, and changing the typehint in the function. Other functions that were typehinted with `Owner` instead of `Optional[Owner]` are also changed.
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jan 26, 2024
These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jan 29, 2024
These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model definitions for GithubAppInstallation.
This will unlock multiple apps for an org.
It also will improve how we keep track of what repos
an installation can access.
context: codecov/engineering-team#969
this is PR 1 of 2