Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync providers change #348

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: sync providers change #348

merged 4 commits into from
Jan 19, 2024

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

Update sync providers GQL

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@@ -6,34 +6,46 @@

import services.self_hosted as self_hosted
from codecov.db import sync_to_async
from codecov_auth.models import Service
from graphql_api.types.enums.enums import LoginProvider

config_bindable = ObjectType("Config")


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff makes it look confusing, its just some refactoring, it's better to compare file side by side

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (635ff36) 95.70% compared to head (3bd8293) 95.70%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #348   +/-   ##
=====================================
  Coverage   95.70   95.70           
=====================================
  Files        740     740           
  Lines      16712   16715    +3     
=====================================
+ Hits       15993   15996    +3     
  Misses       719     719           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jan 18, 2024

Codecov Report

Merging #348 (3bd8293) into main (635ff36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         625      625           
  Lines       16196    16199    +3     
=======================================
+ Hits        15560    15563    +3     
  Misses        636      636           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/config/config.py 100.00% <100.00%> (ø)

Impacted file tree graph

@codecov-qa
Copy link

codecov-qa bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (635ff36) 96.07% compared to head (3bd8293) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         625      625           
  Lines       16196    16199    +3     
=======================================
+ Hits        15560    15563    +3     
  Misses        636      636           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry merged commit dca8ae6 into main Jan 19, 2024
21 checks passed
@JerrySentry JerrySentry deleted the api_947b branch January 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants