Revert "feat: use GithubAppInstallation in api (#347)" #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86178ba. This commit caused auth issues with `/graphql` endpoint in which users were not authenticated and couldn't see source code. Revertign for now while we figure out the exact issue and fix it.
trent-codecov
approved these changes
Jan 24, 2024
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 96.06% 96.05% -0.01%
==========================================
Files 628 628
Lines 16357 16307 -50
==========================================
- Hits 15713 15664 -49
+ Misses 644 643 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 96.06% 96.05% -0.01%
==========================================
Files 628 628
Lines 16357 16307 -50
==========================================
- Hits 15713 15664 -49
+ Misses 644 643 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
added a commit
that referenced
this pull request
Jan 25, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Jan 30, 2024
* Revert "Revert "feat: use GithubAppInstallation in api (#347)" (#355)" This reverts commit 226f73d. * fix: logged in users can't see coverage bug This bug caused a little incident in Codecov. The actual issue is that we can't make DB queries syncronously from an async context. When getting the file content we have to get an adapter, and that - since the GithubAppInstallation work - required a query to the database to get the default GithubAppInstallation for an `owner`. That was the actual error that caused the incident. Error surfacing was terrible in that endpoint so I changed the `info` log from an `exception` one so we can have a stacktrace. To actually fix the error I actually created an async version of `get_adapter`. I scanned the code, but it seems that this instance is the only place where we actually use this. * fix tests Tests for the interactor (which is async) are now marked as `async`. I believe that marking them with `@async_to_sync` instead of `pytest.mark.async` may have hidden the bug that we faced about running the DB query in the async context. Not tested this theory tho. * add more unit tests to async paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 86178ba.
This commit caused auth issues with
/graphqlendpoint in which users were not authenticated and couldn't see source code.Revertign for now while we figure out the exact issue and fix it.
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.