Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use timestamp of commit instead of updatestamp in get_or_update_branch_head #356

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

joseph-sentry
Copy link
Contributor

Purpose/Motivation

timestamp is the field which we were using before to decide if a commit was to be branch's head or not. The issue with ordering by updatestamp is that updatestamp is nullable which leads to incorrect behaviour where we may pick a commit from very long ago to be the branch head.

What does this PR do?

  • order by timestamp descending instead of updatestamp descending

…branch_head

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@joseph-sentry joseph-sentry force-pushed the joseph/use-timestamp-desc-branch-fix branch from cafb9dd to 390b137 Compare January 24, 2024 18:55
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (226f73d) 95.73% compared to head (390b137) 95.73%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #356   +/-   ##
=====================================
  Coverage   95.73   95.73           
=====================================
  Files        743     743           
  Lines      16823   16823           
=====================================
  Hits       16104   16104           
  Misses       719     719           
Flag Coverage Δ
unit 96.05% <ø> (ø)
unit-latest-uploader 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (226f73d) 96.05% compared to head (390b137) 96.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         628      628           
  Lines       16307    16307           
=======================================
  Hits        15664    15664           
  Misses        643      643           
Flag Coverage Δ
unit 96.05% <ø> (ø)
unit-latest-uploader 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #356 (390b137) into main (226f73d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         628      628           
  Lines       16307    16307           
=======================================
  Hits        15664    15664           
  Misses        643      643           
Flag Coverage Δ
unit 96.05% <ø> (ø)
unit-latest-uploader 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
utils/temp_branch_fix.py 90.90% <ø> (ø)

Impacted file tree graph

@joseph-sentry joseph-sentry merged commit 0e58149 into main Jan 24, 2024
22 checks passed
@joseph-sentry joseph-sentry deleted the joseph/use-timestamp-desc-branch-fix branch January 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants