Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for configurable Stripe keys in dev #36

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Jul 26, 2023

These are fake values that need to be overridden in local development. Reading from the config allows us to instead specify these keys in the Codecov install YAML locally.

The tests depend on some non-null value there so I just put "default" as the default.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #36 (822d120) into main (803dc0c) will not change coverage.
The diff coverage is 100.00%.

@@          Coverage Diff          @@
##            main     #36   +/-   ##
=====================================
  Coverage   95.26   95.26           
=====================================
  Files        691     691           
  Lines      14622   14622           
=====================================
  Hits       13929   13929           
  Misses       693     693           
Flag Coverage Δ
unit 95.20% <100.00%> (ø)
unit-latest-uploader 95.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
codecov/settings_dev.py 100.00% <100.00%> (ø)

@hootener
Copy link

hootener commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (803dc0c) 95.20% compared to head (822d120) 95.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         578      578           
  Lines       14451    14451           
=======================================
  Hits        13758    13758           
  Misses        693      693           
Flag Coverage Δ
unit 95.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
codecov/settings_dev.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-codecov scott-codecov merged commit 030c0ca into main Aug 2, 2023
10 checks passed
@scott-codecov scott-codecov deleted the scott/stripe-dev-config branch August 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants