Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gazebo-previews): update CORS header for API to allow our self-hosted previews #361

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

rfox-codecov
Copy link
Contributor

https://github.com/codecov/infrastructure-team/issues/174

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3caddf5) 95.75% compared to head (0b3958d) 95.75%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #361   +/-   ##
=====================================
  Coverage   95.75   95.75           
=====================================
  Files        747     747           
  Lines      16926   16926           
=====================================
  Hits       16206   16206           
  Misses       720     720           
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3caddf5) 96.07% compared to head (0b3958d) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         632      632           
  Lines       16408    16408           
=======================================
  Hits        15764    15764           
  Misses        644      644           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #361 (0b3958d) into main (3caddf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         632      632           
  Lines       16408    16408           
=======================================
  Hits        15764    15764           
  Misses        644      644           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_staging.py 0.00% <ø> (ø)

Impacted file tree graph

@rfox-codecov rfox-codecov merged commit 952dedd into main Jan 26, 2024
22 checks passed
@rfox-codecov rfox-codecov deleted the rf/gazebo-previews branch January 26, 2024 01:14
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants