Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update shared #365

Merged
merged 3 commits into from
Jan 31, 2024
Merged

update shared #365

merged 3 commits into from
Jan 31, 2024

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

update shared code to latest

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d51fa4) 95.77% compared to head (523b64a) 95.75%.

❗ Current head 523b64a differs from pull request most recent head 60a0655. Consider uploading reports for the commit 60a0655 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #365     +/-   ##
=======================================
- Coverage   95.77   95.75   -0.02     
=======================================
  Files        747     747             
  Lines      16988   16927     -61     
=======================================
- Hits       16269   16208     -61     
  Misses       719     719             
Flag Coverage Δ
unit 96.08% <ø> (-0.01%) ⬇️
unit-latest-uploader 96.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d51fa4) 96.08% compared to head (60a0655) 96.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         632      632           
  Lines       16470    16470           
=======================================
  Hits        15826    15826           
  Misses        644      644           
Flag Coverage Δ
unit 96.08% <ø> (ø)
unit-latest-uploader 96.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 29, 2024

Codecov Report

Merging #365 (60a0655) into main (0d51fa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         632      632           
  Lines       16470    16470           
=======================================
  Hits        15826    15826           
  Misses        644      644           
Flag Coverage Δ
unit 96.08% <ø> (ø)
unit-latest-uploader 96.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@JerrySentry JerrySentry merged commit d441c98 into main Jan 31, 2024
20 checks passed
@JerrySentry JerrySentry deleted the api_1109 branch January 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants