fix: remove branch.refresh_from_db from branch serializer #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
drazisil-codecov
approved these changes
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 96.08% 96.08% -0.01%
==========================================
Files 632 632
Lines 16410 16409 -1
==========================================
- Hits 15767 15766 -1
Misses 643 643
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 96.08% 96.08% -0.01%
==========================================
Files 632 632
Lines 16410 16409 -1
==========================================
- Hits 15767 15766 -1
Misses 643 643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
using
refresh_from_dbon a branch object causes a similar issue as trying to update a branch object and saving using the django orm due to the primary key of the django model only being part of the actual composite primary key of the postgres tableLinks to relevant tickets
Relevant ticket
What does this PR do?
branch.refresh_from_dbget_or_update_branch_head