Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle no uploads check #373

Merged
merged 4 commits into from
Feb 6, 2024
Merged

fix: handle no uploads check #373

merged 4 commits into from
Feb 6, 2024

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

Handle the case when commit report is created, but can't load report for some reason (eg upload failed)

Links to relevant tickets

codecov/engineering-team#1139

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7937757) 96.06% compared to head (a216c73) 96.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         634      634           
  Lines       16535    16538    +3     
=======================================
+ Hits        15885    15888    +3     
  Misses        650      650           
Flag Coverage Δ
unit 96.06% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 5, 2024

Codecov Report

Merging #373 (a216c73) into main (7937757) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         634      634           
  Lines       16535    16538    +3     
=======================================
+ Hits        15885    15888    +3     
  Misses        650      650           
Flag Coverage Δ
unit 96.06% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/dataloader/bundle_analysis.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7937757) 95.75% compared to head (0323267) 95.76%.

❗ Current head 0323267 differs from pull request most recent head a216c73. Consider uploading reports for the commit a216c73 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #373     +/-   ##
=======================================
+ Coverage   95.75   95.76   +0.01     
=======================================
  Files        749     749             
  Lines      17053   17051      -2     
=======================================
  Hits       16328   16328             
+ Misses       725     723      -2     
Flag Coverage Δ
unit 96.08% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry merged commit 19cb467 into main Feb 6, 2024
20 checks passed
@JerrySentry JerrySentry deleted the api_1139 branch February 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants