Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo temp branch fix #385

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Feb 8, 2024

Purpose/Motivation

this fix is having a negative effect on the db

What does this PR do?

  • removing the temp branch fix file
  • removing all calls to the get or update branch head, and just using the branch head
  • undo breaking changes to tests

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f936e) 96.07% compared to head (b169076) 96.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         634      633       -1     
  Lines       16570    16552      -18     
==========================================
- Hits        15920    15902      -18     
  Misses        650      650              
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f936e) 96.07% compared to head (b169076) 96.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         634      633       -1     
  Lines       16570    16552      -18     
==========================================
- Hits        15920    15902      -18     
  Misses        650      650              
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/coverage/views.py 100.00% <100.00%> (ø)
api/public/v2/branch/serializers.py 100.00% <ø> (ø)
api/shared/mixins.py 98.52% <100.00%> (-0.03%) ⬇️
graphql_api/types/branch/branch.py 100.00% <100.00%> (ø)
graphs/views.py 92.85% <100.00%> (-0.15%) ⬇️

Impacted file tree graph

@joseph-sentry joseph-sentry merged commit e1508e5 into main Feb 8, 2024
20 checks passed
@joseph-sentry joseph-sentry deleted the joseph/undo-temp-branch-fix branch February 8, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants