Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joseph/update webhooks #394

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Joseph/update webhooks #394

merged 7 commits into from
Feb 15, 2024

Conversation

joseph-sentry
Copy link
Contributor

Purpose/Motivation

We want to ignore the push webhook for repositories by name

@codecov-qa
Copy link

codecov-qa bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f6c26d) 96.07% compared to head (67c201d) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         636      636           
  Lines       16576    16581    +5     
=======================================
+ Hits        15926    15931    +5     
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f6c26d) 96.07% compared to head (67c201d) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         636      636           
  Lines       16576    16581    +5     
=======================================
+ Hits        15926    15931    +5     
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webhook_handlers/constants.py 100.00% <100.00%> (ø)
webhook_handlers/views/github.py 99.00% <100.00%> (+0.01%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fdd47db) 95.76% compared to head (c511e76) 95.75%.

❗ Current head c511e76 differs from pull request most recent head 4ca1d91. Consider uploading reports for the commit 4ca1d91 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Files Patch % Lines
webhook_handlers/views/github.py Critical 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #394     +/-   ##
=======================================
- Coverage   95.76   95.75   -0.01     
=======================================
  Files        750     750             
  Lines      17088   17093      +5     
=======================================
+ Hits       16363   16366      +3     
- Misses       725     727      +2     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry merged commit f0f67d9 into main Feb 15, 2024
20 checks passed
@joseph-sentry joseph-sentry deleted the joseph/update-webhooks branch February 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants