Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix None type is not iterable #400

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Update to fix None type is not iterable #400

merged 2 commits into from
Feb 19, 2024

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
https://codecov.sentry.io/issues/4397595099/events/91119ea02bc748feb29345d9664ccc8a/

Links to relevant tickets

https://github.com/codecov/internal-issues/issues/287

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5286410) 96.07% compared to head (187cbe3) 96.08%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   96.07%   96.08%           
=======================================
  Files         636      636           
  Lines       16581    16583    +2     
=======================================
+ Hits        15931    15933    +2     
  Misses        650      650           
Flag Coverage Δ
unit 96.08% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/activation.py 93.10% <100.00%> (+0.24%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5286410) 95.76% compared to head (dd457f5) 95.76%.

❗ Current head dd457f5 differs from pull request most recent head 187cbe3. Consider uploading reports for the commit 187cbe3 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #400   +/-   ##
=====================================
  Coverage   95.76   95.76           
=====================================
  Files        752     752           
  Lines      17101   17098    -3     
=====================================
- Hits       16376   16373    -3     
  Misses       725     725           
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5286410) 96.07% compared to head (187cbe3) 96.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   96.07%   96.08%           
=======================================
  Files         636      636           
  Lines       16581    16583    +2     
=======================================
+ Hits        15931    15933    +2     
  Misses        650      650           
Flag Coverage Δ
unit 96.08% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled merged commit c1cecfa into main Feb 19, 2024
20 checks passed
@RulaKhaled RulaKhaled deleted the activation-bug branch February 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants