chore: remove rollout check on test result endpoint #403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
- Coverage 95.80 95.78 -0.02
=======================================
Files 757 757
Lines 17275 17268 -7
=======================================
- Hits 16550 16540 -10
- Misses 725 728 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.03%
==========================================
Files 637 637
Lines 16693 16686 -7
==========================================
- Hits 16043 16032 -11
- Misses 650 654 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.03%
==========================================
Files 637 637
Lines 16693 16686 -7
==========================================
- Hits 16043 16032 -11
- Misses 650 654 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/rm-test-result-rollout
branch
2 times, most recently
from
b39bed7
to
74d3a95
Compare
|
Just curious, why are we removing this rollout? Do we just want it enabled for everyone now? |
| @@ -5,18 +5,3 @@ | |||
|
|
|||
| def owner_slug(owner: Owner) -> str: | |||
There was a problem hiding this comment.
should this get deleted too?
There was a problem hiding this comment.
I think it's fine to leave this here, it might end up being useful next time someone wants to use a rollout
There was a problem hiding this comment.
I don't think so... that is a helper function, not directly related to this rollout. We can reuse that for future rollouts.
(even if there aren't none right now 😅)
joseph-sentry
force-pushed
the
joseph/rm-test-result-rollout
branch
from
74d3a95
to
ab7394a
Compare
yeah, we were running into problems where people would want to try it out but they would get blocked on this |
| @@ -5,18 +5,3 @@ | |||
|
|
|||
| def owner_slug(owner: Owner) -> str: | |||
There was a problem hiding this comment.
I don't think so... that is a helper function, not directly related to this rollout. We can reuse that for future rollouts.
(even if there aren't none right now 😅)
No description provided.