feat: add user agent to prom metrics #404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=======================================
Coverage 96.09% 96.10%
=======================================
Files 637 637
Lines 16654 16671 +17
=======================================
+ Hits 16004 16021 +17
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #404 +/- ##
=======================================
Coverage 96.09% 96.10%
=======================================
Files 637 637
Lines 16654 16671 +17
=======================================
+ Hits 16004 16021 +17
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=====================================
Coverage 95.80 95.80
=====================================
Files 757 757
Lines 17264 17253 -11
=====================================
- Hits 16539 16528 -11
Misses 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
daniel-codecov
changed the title
There was a problem hiding this comment.
awesome work, thanks a ton!
codecov-api automatically deploys when you merge to main so we should wait until monday to merge this in case something goes wrong. wouldn't want to make anyone work late on a friday
also might be a good idea to push to staging first and click around to see if anything crashes. and if there's a staging instance of grafana we can test it end-to-end with a dashboard too
daniel-codecov
changed the title
daniel-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
daniel-codecov
force-pushed
the
daniel/add-user-agent-to-prom-metrics
branch
3 times, most recently
from
bf08a59
to
6d80dec
Compare
daniel-codecov
force-pushed
the
daniel/add-user-agent-to-prom-metrics
branch
from
6d80dec
to
3332852
Compare
Purpose/Motivation
This change adds the User-Agent http header to our prometheus metrics that we expose so that we can have a better understanding of where traffic comes from for our API. We can visualize the data via Grafana by the different User-Agents and it could give us insights in how our users use the codecov cli, uploader, etc..
What does this PR do?
Notes to Reviewer
You can view the exposed metrics at http://localhost:8000/monitoring/metrics, but I wasn't able to try querying in Grafana. Do we need to deploy to staging to test that?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.