extend ghapp model #407
extend ghapp model #407
Conversation
Includes an `app_id` and `pem_path` fields to `GithubAppInstallation` These will be used to manage multiple apps for the same user. They are needed to get a token for the app with github [see here](https://github.com/codecov/shared/blob/8e3e4462c3d8e60e257b6725310c1c653f692a90/shared/github/__init__.py#L46) The `app_id` we can get from installation webhooks. The `pem_path` needs to be configured by the user, and should be a URI pointing to some PEM file for that app. context: codecov/engineering-team#1146
Changes the GithubAppInstallation model to match api's. Depends on #407
giovanni-guidini
force-pushed
the
gio/multiple-gh-apps
branch
from
4c299a1
to
08896b4
Compare
Bring the GithubAppInstallation model to parity with api's Depends on codecov/codecov-api#407
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=====================================
Coverage 95.76 95.76
=====================================
Files 752 752
Lines 17101 17101
=====================================
Hits 16376 16376
Misses 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 636 637 +1
Lines 16583 16589 +6
=======================================
+ Hits 15933 15939 +6
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 636 637 +1
Lines 16583 16589 +6
=======================================
+ Hits 15933 15939 +6
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=====================================
Coverage 95.76 95.76
=====================================
Files 752 753 +1
Lines 17103 17107 +4
=====================================
+ Hits 16378 16382 +4
Misses 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bring the GithubAppInstallation model to parity with api's Depends on codecov/codecov-api#407
Includes an
app_idandpem_pathfields toGithubAppInstallationThese will be used to manage multiple apps for the same user.
They are needed to get a token for the app with github see here
The
app_idwe can get from installation webhooks.The
pem_pathneeds to be configured by the user, and should bea URI pointing to some PEM file for that app.
context: codecov/engineering-team#1146
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.