Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cors origin regex configuration #409

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

trent-codecov
Copy link
Contributor

Allow for env configuration of this setting

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64a6de2) 96.10% compared to head (5d8cdd5) 96.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         637      637           
  Lines       16693    16693           
=======================================
  Hits        16043    16043           
  Misses        650      650           
Flag Coverage Δ
unit 96.10% <100.00%> (ø)
unit-latest-uploader 96.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64a6de2) 96.10% compared to head (5d8cdd5) 96.10%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         637      637           
  Lines       16693    16693           
=======================================
  Hits        16043    16043           
  Misses        650      650           
Flag Coverage Δ
unit 96.10% <100.00%> (ø)
unit-latest-uploader 96.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 85.71% <100.00%> (ø)

Impacted file tree graph

Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trent-codecov trent-codecov merged commit a734bb2 into main Feb 22, 2024
19 of 20 checks passed
@trent-codecov trent-codecov deleted the trent/cors-origin-regex-config branch February 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants