Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user check to customer intent resolver #410

Merged

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Feb 22, 2024

Purpose/Motivation

Fixes these issues on Sentry. The user subtype on the owner may be undefined so we will return None for the customer intent in that case.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/add-check-customer-intent-resolver branch from 7ecbe57 to c33dc65 Compare February 22, 2024 20:06
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.07%. Comparing base (1db5bd6) to head (c33dc65).
Report is 4 commits behind head on main.

❗ Current head c33dc65 differs from pull request most recent head 7a105fd. Consider uploading reports for the commit 7a105fd to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Files Patch % Lines
graphql_api/types/user/user.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #410     +/-   ##
=======================================
- Coverage   95.80   94.07   -1.73     
=======================================
  Files        757     757             
  Lines      17250   17653    +403     
=======================================
+ Hits       16525   16606     +81     
- Misses       725    1047    +322     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/add-check-customer-intent-resolver branch from 397c137 to c33dc65 Compare February 22, 2024 20:50
@codecov-staging
Copy link

codecov-staging bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (32cd036) to head (8bcaa81).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         643      643           
  Lines       17120    17122    +2     
=======================================
+ Hits        16446    16448    +2     
  Misses        674      674           
Flag Coverage Δ
unit 96.06% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32cd036) 96.06% compared to head (8bcaa81) 96.06%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         643      643           
  Lines       17120    17122    +2     
=======================================
+ Hits        16446    16448    +2     
  Misses        674      674           
Flag Coverage Δ
unit 96.06% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/user/user.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/add-check-customer-intent-resolver branch from 6bf9684 to 60b21e6 Compare March 6, 2024 20:46
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review March 6, 2024 20:54
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner March 6, 2024 20:54
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 86ad9b1 into main Mar 14, 2024
17 of 18 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-check-customer-intent-resolver branch March 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants