Bundle Analysis v0.5 - GQL refresh #412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 96.08% 96.11% +0.02%
==========================================
Files 637 637
Lines 16712 16819 +107
==========================================
+ Hits 16058 16165 +107
Misses 654 654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 96.08% 96.11% +0.02%
==========================================
Files 637 637
Lines 16712 16819 +107
==========================================
+ Hits 16058 16165 +107
Misses 654 654
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
+ Coverage 95.79 95.82 +0.03
=======================================
Files 757 757
Lines 17295 17400 +105
=======================================
+ Hits 16567 16672 +105
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -42,6 +46,26 @@ def load_time_conversion(size): | |||
| return round((8 * size) / (1024 * 1024 * 3), 1) | |||
|
|
|||
|
|
|||
| def get_extension(filename: str) -> str: | |||
There was a problem hiding this comment.
Is this something that could be in shared? I'm trying to think what's a good etiquette we can adopt for knowing what should/shouldn't be in shared.
For instance, I can see this being shared logic, but there's not an apparent usecase for it atm, but in the future it would be 2x work to get move this you know
There was a problem hiding this comment.
Yeah I agree it is hard to determine if it should be in shared or not. My thinking (and current implementation) is that any data fetching and data aggregation should be in shared, whereas any form of data manipulation/transformation for the purpose of displaying the values to end users should be on their own codebases.
I suppose whenever the use case for PR comments to display the same info as the UI comes, then it may make more sense at that time to migrate this to shared.
Note: Update Shared commit once codecov/shared#132 is pushed.
Add module and asset reporting for bundle analysis.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.