Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sentry metrics set to legacy endpoint #422

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

joseph-sentry
Copy link
Contributor

Purpose/Motivation

We want a percentage of orgs using the CLI vs using the uploader.

This sentry metrics set was previously added to the new upload endpoint.

What does this PR do?

  • Add sentry_metrics.set call to the legacy upload endpoint

@joseph-sentry joseph-sentry requested a review from a team as a code owner February 27, 2024 14:26
@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff5671) 96.11% compared to head (cea9606) 96.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         637      637           
  Lines       16821    16823    +2     
=======================================
+ Hits        16167    16169    +2     
  Misses        654      654           
Flag Coverage Δ
unit 96.11% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/views/legacy.py 95.56% <100.00%> (+0.04%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (9ff5671) to head (02cafea).

❗ Current head 02cafea differs from pull request most recent head cea9606. Consider uploading reports for the commit cea9606 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #422   +/-   ##
=====================================
  Coverage   95.82   95.82           
=====================================
  Files        757     757           
  Lines      17404   17406    +2     
=====================================
+ Hits       16676   16678    +2     
  Misses       728     728           
Flag Coverage Δ
unit 96.11% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (9ff5671) to head (cea9606).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         637      637           
  Lines       16821    16823    +2     
=======================================
+ Hits        16167    16169    +2     
  Misses        654      654           
Flag Coverage Δ
unit 96.11% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry merged commit ccd3fee into main Feb 27, 2024
19 of 20 checks passed
@joseph-sentry joseph-sentry deleted the joseph/sentry-metrics-set-legacy branch February 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants