Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api dev.sh timeseries migrations as well #432

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

matt-codecov
Copy link
Contributor

weren't doing it before

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@matt-codecov matt-codecov marked this pull request as ready for review March 4, 2024 21:21
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (3ff9a9d) to head (36a3d90).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #432   +/-   ##
=====================================
  Coverage   95.75   95.75           
=====================================
  Files        765     765           
  Lines      17630   17630           
=====================================
  Hits       16881   16881           
  Misses       749     749           
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (b99b186) to head (cde7103).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         643      643           
  Lines       17055    17055           
=======================================
  Hits        16380    16380           
  Misses        675      675           
Flag Coverage Δ
unit 96.04% <ø> (ø)
unit-latest-uploader 96.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b99b186) 96.04% compared to head (cde7103) 96.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         643      643           
  Lines       17055    17055           
=======================================
  Hits        16380    16380           
  Misses        675      675           
Flag Coverage Δ
unit 96.04% <ø> (ø)
unit-latest-uploader 96.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@matt-codecov matt-codecov merged commit f8512f8 into main Mar 6, 2024
19 of 20 checks passed
@matt-codecov matt-codecov deleted the matt-codecov-patch-1 branch March 6, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants