-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Restore Github OIDC Auth #435
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention:
@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 96.05% 96.04% -0.01%
==========================================
Files 644 644
Lines 17136 17151 +15
==========================================
+ Hits 16460 16473 +13
- Misses 676 678 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c175d15
to
1fae5cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 96.05% 96.04% -0.01%
==========================================
Files 644 644
Lines 17136 17151 +15
==========================================
+ Hits 16460 16473 +13
- Misses 676 678 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=====================================
Coverage 95.78 95.78
=====================================
Files 765 765
Lines 17708 17721 +13
=====================================
+ Hits 16960 16973 +13
Misses 748 748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1fae5cd
to
c5de82f
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
c5de82f
to
ddbc855
Compare
Update since this has been hanging |
ddbc855
to
597893a
Compare
597893a
to
5d59860
Compare
5d59860
to
e3d093d
Compare
e3d093d
to
7c1f970
Compare
7c1f970
to
ed959f9
Compare
Purpose/Motivation
Codecov CLI needs to be able to use Github OIDC for Authentication on upload endpoints.
Links to relevant tickets
codecov/engineering-team#1217
What does this PR do?
Adds new authentication class
GitHubOIDCTokenAuthentication
to upload viewsNotes to Reviewer
Added one question in test_uploads, line 554, about which
token
to track