Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Restore Github OIDC Auth #435

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Bug: Restore Github OIDC Auth #435

merged 8 commits into from
Apr 2, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Codecov CLI needs to be able to use Github OIDC for Authentication on upload endpoints.

Links to relevant tickets

codecov/engineering-team#1217

What does this PR do?

Adds new authentication class GitHubOIDCTokenAuthentication to upload views

Notes to Reviewer

Added one question in test_uploads, line 554, about which token to track

@nora-codecov nora-codecov requested a review from a team as a code owner March 5, 2024 22:45
@codecov-staging
Copy link

codecov-staging bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Files Patch % Lines
codecov/settings_prod.py 0.00% 1 Missing ⚠️
codecov/settings_staging.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Mar 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (42f597e) 96.05% compared to head (ed959f9) 96.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   96.05%   96.04%   -0.01%     
==========================================
  Files         644      644              
  Lines       17136    17151      +15     
==========================================
+ Hits        16460    16473      +13     
- Misses        676      678       +2     
Flag Coverage Δ
unit 96.04% <93.54%> (-0.01%) ⬇️
unit-latest-uploader 96.04% <93.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_dev.py 100.00% <100.00%> (ø)
codecov/settings_test.py 100.00% <100.00%> (ø)
codecov_auth/authentication/repo_auth.py 98.40% <100.00%> (+0.11%) ⬆️
upload/helpers.py 94.58% <100.00%> (-0.04%) ⬇️
upload/views/bundle_analysis.py 98.41% <ø> (ø)
upload/views/commits.py 100.00% <ø> (ø)
upload/views/empty_upload.py 91.04% <ø> (-0.14%) ⬇️
upload/views/reports.py 100.00% <ø> (ø)
upload/views/test_results.py 98.33% <100.00%> (ø)
upload/views/upload_completion.py 100.00% <ø> (ø)
... and 3 more

Impacted file tree graph

@codecov-qa
Copy link

codecov-qa bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.04%. Comparing base (42f597e) to head (ed959f9).

Files Patch % Lines
codecov/settings_prod.py 0.00% 1 Missing ⚠️
codecov/settings_staging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   96.05%   96.04%   -0.01%     
==========================================
  Files         644      644              
  Lines       17136    17151      +15     
==========================================
+ Hits        16460    16473      +13     
- Misses        676      678       +2     
Flag Coverage Δ
unit 96.04% <93.54%> (-0.01%) ⬇️
unit-latest-uploader 96.04% <93.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (13decc6) to head (597893a).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #435   +/-   ##
=====================================
  Coverage   95.78   95.78           
=====================================
  Files        765     765           
  Lines      17708   17721   +13     
=====================================
+ Hits       16960   16973   +13     
  Misses       748     748           
Flag Coverage Δ
unit 96.06% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

upload/views/uploads.py Show resolved Hide resolved
@codecov-test
Copy link

codecov-test commented Mar 9, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@nora-codecov
Copy link
Contributor Author

Update since this has been hanging open for a while - we found a blocker further upstream, will have to wait on that to be merged before these changes can be tested and merged.

@nora-codecov nora-codecov merged commit 66f41fc into main Apr 2, 2024
14 of 20 checks passed
@nora-codecov nora-codecov deleted the nora/bug-1217 branch April 2, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants