[admin] allow trial extension for orgs currently on trial #438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage ? 96.06%
=======================================
Files ? 643
Lines ? 17096
Branches ? 0
=======================================
Hits ? 16423
Misses ? 673
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage ? 96.06%
=======================================
Files ? 643
Lines ? 17096
Branches ? 0
=======================================
Hits ? 16423
Misses ? 673
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
=====================================
Coverage 95.75 95.75
=====================================
Files 765 765
Lines 17643 17643
=====================================
Hits 16894 16894
Misses 749 749
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| org_to_be_trialed.save() | ||
|
|
||
| res = self.client.post( | ||
| reverse("admin:codecov_auth_owner_changelist"), |
There was a problem hiding this comment.
looked this up, honestly a pretty interesting django feature lol
plan/service.py
Outdated
| self, current_owner: Owner, end_date: datetime = None | ||
| self, | ||
| current_owner: Owner, | ||
| end_date: datetime = None, |
There was a problem hiding this comment.
This should be datetime | None for the type right?
There was a problem hiding this comment.
Yes, updated to end_date: Optional[datetime] = None
Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan. This change allows the orgs' trials to be extended while they're still trialing.
* Test with states * second round * Okta stuff * quick fix for test * fixing tests * more tests * test: fix query measurements after 30 days test (#442) * test: fix query measurements after 30 days test This test started failing ater 2024-03-10 because the time at the query was not frozen to a specific date so it was using the system's actual time and the measurements were not a part of the last 30 days. * fix: add comments to clarify test fix Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> * [admin] allow trial extension for orgs currently on trial (#438) Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan. This change allows the orgs' trials to be extended while they're still trialing. * Bundle Analysis: delete old code (#444) These fields are being deprecated by bundleData and bundleChange. The app is no longer calling these fields anymore, it is safe to remove now. * fix: use get_or_create in CommitSerializer.create (#437) * fix: use get_or_create in CommitSerializer.create there is a possibility of creating commits concurrently if that happens there is a possibility of getting an IntegrityError when trying to create the Commit object this commit solves this problem by using get_or_create to create the Commit object in the serializer * test: add test to make sure CommitSerializer create only creates one object in the db --------- Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> * Revert "Bundle Analysis: delete old code (#444)" (#445) This reverts commit 7932e93. * Remove state after login --------- Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> Co-authored-by: joseph-sentry <136376984+joseph-sentry@users.noreply.github.com> Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com>
Purpose/Motivation
What is the feature? Why is this being done?
Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan.
This change allows the orgs' trials to be extended while they're still trialing.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.