Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source query param to validate v2 endpoint #472

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Purpose/Motivation

We currently have no visibility into how much our vscode extension is being used outside of install counts. This PR, paired with the corresponding change to our vscode extension, will allow us to see how frequently the validate YAML endpoint is being hit from the extension.

Part of #441

What does this PR do?

  • Add a 'source' query param to the validate v2 endpoint

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (f255726) to head (e0b4be5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         652      652           
  Lines       17294    17297    +3     
=======================================
+ Hits        16624    16627    +3     
  Misses        670      670           
Flag Coverage Δ
unit 96.12% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (f255726) to head (e0b4be5).

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         652      652           
  Lines       17294    17297    +3     
=======================================
+ Hits        16624    16627    +3     
  Misses        670      670           
Flag Coverage Δ
unit 96.12% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
validate/views.py 100.00% <100.00%> (ø)

Impacted file tree graph

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 28, 2024 16:54
validate/views.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (b8eb29a) to head (2f48fee).

❗ Current head 2f48fee differs from pull request most recent head ce4e07d. Consider uploading reports for the commit ce4e07d to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #472   +/-   ##
=====================================
  Coverage   95.78   95.78           
=====================================
  Files        766     766           
  Lines      17752   17752           
=====================================
  Hits       17002   17002           
  Misses       750     750           
Flag Coverage Δ
unit 96.05% <100.00%> (ø)
unit-latest-uploader 96.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov merged commit 6562437 into main Apr 5, 2024
19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spencer/validate-source-param branch April 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants