make is_configured more rebust
#474
Conversation
Recently an enterprise customer had a ghapp instance of the default
app change names to `unconfigured_app` even though it is the default
app.
One possible explanation is that in the YAML the default app id is a string,
not a number. This small change is to catch that case.
The motivation is:
```
>>> 10 == 10
True
>>> 10 == '10'
False
>>> str(10) == str('10')
True
```
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 643 643
Lines 17127 17127
=======================================
Hits 16451 16451
Misses 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 643 643
Lines 17127 17127
=======================================
Hits 16451 16451
Misses 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=====================================
Coverage 95.78 95.78
=====================================
Files 765 765
Lines 17713 17713
=====================================
Hits 16965 16965
Misses 748 748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Recently an enterprise customer had a ghapp instance of the default
app change names to
unconfigured_appeven though it is the defaultapp.
One possible explanation is that in the YAML the default app id is a string,
not a number. This small change is to catch that case.
The motivation is:
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.