feat: pass region to minio storage backend #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
imnotjames
force-pushed
the
chore/minio-region
branch
from
76946d6
to
4af2bbd
Compare
|
related to codecov/shared#167 |
|
I've merged |
|
Anything I can do to help this get reviewed? I'd be thrilled to not have to patch the docker container to support this feature. |
trent-codecov
approved these changes
Apr 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Oh, cool, merge queue! Y'all rock, thanks. |
|
You are the actually the first PR we have done this with. Congrats!! and thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
without the region being set in the minio client, using codecov with garage, the s3 compatible storage system fails
Links to relevant tickets
dependent on codecov/shared#167 being merged inGood to go!What does this PR do?
allow a user to set the minio client region when creating a client
bumps thesharedversion from203b67e8b0fb066f7dde8dcfb53896c20c28b06etoa5b50e79697350abe9305a36bb10f23ef71827aeSee commits that this will bring in hererequirements.txt&requirements.inalready have the commit needed fromshared(a5b50e79697350abe9305a36bb10f23ef71827ae)Notes to Reviewer
tested with garage 0.9.3 and minio (whatever the
latesttag points at)Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.