Coverage over time components #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add component count resolver and related tests * lint
Add a GQL mutation to delete component measurements
Add a GQL resolver to retrieve measurements of components for a given repo.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 96.05% 96.12% +0.07%
==========================================
Files 644 651 +7
Lines 17166 17301 +135
==========================================
+ Hits 16488 16630 +142
+ Misses 678 671 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 96.05% 96.12% +0.07%
==========================================
Files 644 651 +7
Lines 17166 17301 +135
==========================================
+ Hits 16488 16630 +142
+ Misses 678 671 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes |
ajay-sentry
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
Add in all the necessary changes to enable coverage over time for components
Links to relevant tickets
codecov/engineering-team#1358
codecov/engineering-team#1359
codecov/engineering-team#1368
codecov/engineering-team#1360
codecov/engineering-team#1361
Notes to Reviewer
This giant PR is a result of many approved PR merged into this branch while the code freeze was in progress. All code in the changes here have been reviewed and approved.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.