Warn when ghapps flip names #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had again a situation in staging that the default app flipped names to 'unconfigured_app'. Not sure why exactly, but it's anoying and disruptive. These changes emit a warning when the app flips name to unconfigured so we can track better that situation (but we hope it doesn't happen much) and hopefully get better understanding on why it's happening. I also made a change to the `is_configured` function that an app unconfigured is never configured.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 96.04% 96.05%
=======================================
Files 644 644
Lines 17163 17166 +3
=======================================
+ Hits 16485 16488 +3
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 96.04% 96.05%
=======================================
Files 644 644
Lines 17163 17166 +3
=======================================
+ Hits 16485 16488 +3
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adrian-codecov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had again a situation in staging that the default app flipped names to 'unconfigured_app'.
Not sure why exactly, but it's anoying and disruptive.
These changes emit a warning when the app flips name to unconfigured so we can track better
that situation (but we hope it doesn't happen much) and hopefully get better understanding
on why it's happening.
I also made a change to the
is_configuredfunction that an app unconfigured is never configured.Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.