Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return component coverage percentage in public components list api #517

Merged

Conversation

spalmurray-codecov
Copy link
Contributor

Title. User suggestion, seems like a nice to have feature!

Closes codecov/feedback#150

@codecov-qa
Copy link

codecov-qa bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (8a4bc2e) to head (cbf663c).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files         599      599           
  Lines       16177    16184    +7     
=======================================
+ Hits        14792    14799    +7     
  Misses       1385     1385           
Flag Coverage Δ
unit 91.44% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (8a4bc2e) to head (cbf663c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files         599      599           
  Lines       16177    16184    +7     
=======================================
+ Hits        14792    14799    +7     
  Misses       1385     1385           
Flag Coverage Δ
unit 91.44% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/public/v2/component/serializers.py 100.00% <100.00%> (ø)
api/public/v2/component/views.py 100.00% <100.00%> (ø)

Impacted file tree graph

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review April 19, 2024 19:17
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing blocking, just a couple ideas

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found ☺️

📢 Thoughts on this report? Let us know!

@spalmurray-codecov spalmurray-codecov merged commit bee1d67 into main Apr 22, 2024
19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/component-coverage-percent-public-api branch April 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Component list should also contain the coverage percentage for each component
2 participants